-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement physics params and trackview #141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 11, 2021
sethrj
force-pushed
the
physics-params
branch
from
February 11, 2021 14:03
d06f00a
to
2137cbe
Compare
sethrj
force-pushed
the
physics-params
branch
from
February 11, 2021 22:34
9ac0524
to
cabb849
Compare
sethrj
changed the title
Complete physics params implementation
Implement physics params construction and physics track interface
Feb 11, 2021
sethrj
changed the title
Implement physics params construction and physics track interface
Implement physics params and trackview
Feb 11, 2021
sethrj
force-pushed
the
physics-params
branch
from
February 11, 2021 22:38
cabb849
to
d770ad9
Compare
pcanal
approved these changes
Feb 12, 2021
amandalund
approved these changes
Feb 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, @sethrj!
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completess the implementation of the physics track view so that we can do on-device cross section lookups etc. Most of the physics step utils will rely heavily on this implementation.